feat(notifications): Large images are displayed when expanding notifications #2694
Conversation
|
Hey @hirotakaakita, thanks for posting this PR! We will have a look at it and get back to you soon. |
tjleing
changed the title
|
I was able to test this PR last night, and gathered these four screenshots. These first two are of the library in its current state:
and these two are of the library after these changes.
I used the pinpoint test message console, with the image URL placed in the "Android image" section. |
|
Just tested the other scenarios and "Android icon" and "Android small icon" seem to not be used in the notifications, just the "Android image". In my opinion it makes a lot more sense to set this image as the notification image as is seen in this PR, but also that at least Android icon turns into the icon to the left, as was the behavior before. |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2694 +/- ##
==========================================
+ Coverage 42.85% 42.87% +0.01%
==========================================
Files 905 905
Lines 29098 29102 +4
Branches 4142 4142
==========================================
+ Hits 12471 12478 +7
+ Misses 15269 15267 -2
+ Partials 1358 1357 -1 |
|
@tjleing |
|
Sorry, I did not understand the specifications of the pinpoint test message console. |
Issue #, if available:
None
Description of changes:
When displaying a notification with an image through Amplify, there is an issue where the attached image does not enlarge even when in the expanded state. To resolve this, I made changes to the settings based on the official Android documentation. Currently, even when the notification is in the expanded state, the appearance does not change, which I believe is different from the expected behavior by the user.
reference link:
https://developer.android.com/develop/ui/views/notifications/expanded#kotlin
How did you test these changes?
We have not confirmed whether it is accurately reflected in the UI. We executed Lint and cAT to confirm, and Lint was executed without any issues, but cAT originally failed.
Documentation update required?
reference link:
https://docs.amplify.aws/android/build-a-backend/push-notifications/set-up-push-notifications/
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.